Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workaround for old input bug #42

Merged
merged 15 commits into from Feb 24, 2020
Merged

Workaround for old input bug #42

merged 15 commits into from Feb 24, 2020

Conversation

inxilpro
Copy link
Contributor

@inxilpro inxilpro commented Oct 5, 2019

This is a potential fix fr #34

@inxilpro
Copy link
Contributor Author

inxilpro commented Oct 5, 2019

This will force NULL old input values to "" — which I'm not 100% sure is what we want. Gonna sleep on it.

@coveralls
Copy link

coveralls commented Feb 24, 2020 •
edited

Pull Request Test Coverage Report for Build 154

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.135%
Totals Coverage Status
Change from base Build 143: 0.0%
Covered Lines: 1004
Relevant Lines: 1078
💛 - Coveralls

@inxilpro inxilpro merged commit c235392 into master Feb 24, 2020
@inxilpro inxilpro deleted the feature/nullable-old-input branch February 24, 2020 22:12
@inxilpro inxilpro mentioned this pull request Dec 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@inxilpro @coveralls