Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was having trouble installing
bits
in a brand new Laravel 11 app, which installed Carbon v3. Currentlybits
only supports v2.In version 3, the Carbon
->total*
properties are now floats instead of integers (see laravel/framework@d1ff9a8). This was causing any test usingassertSlept
to fail (e.g,$interval->totalMicroseconds === 1
turns into$interval->totalMicroseconds === 1.0
).I added a cast back into an
int
to fix the failing tests--but maybe it would be better to cast tofloat
?