Fix error where links would still open editor eroniously

glideapps · Aug 30, 2022 · 121dfc4 · 121dfc4
1 parent 4fc0af8
commit 121dfc4
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/packages/cells/src/cells/links-cell.tsx b/packages/cells/src/cells/links-cell.tsx
@@ -70,6 +70,7 @@ const renderer: CustomRenderer<LinksCell> = {
         const hovered = onClickSelect(e);
         if (hovered !== undefined) {
             hovered.onClick?.();
+            e.preventDefault();
         }
         return undefined;
     },

diff --git a/packages/core/src/data-editor/data-editor.tsx b/packages/core/src/data-editor/data-editor.tsx
@@ -1591,7 +1591,11 @@ const DataEditorImpl: React.ForwardRefRenderFunction<DataEditorRef, DataEditorPr
                             ]);
                         }
                     }
-                    if (mouse?.previousSelection?.current?.cell !== undefined && gridSelection.current !== undefined) {
+                    if (
+                        !isPrevented.current &&
+                        mouse?.previousSelection?.current?.cell !== undefined &&
+                        gridSelection.current !== undefined
+                    ) {
                         const [selectedCol, selectedRow] = gridSelection.current.cell;
                         const [prevCol, prevRow] = mouse.previousSelection.current.cell;
                         if (col === selectedCol && col === prevCol && row === selectedRow && row === prevRow) {