Prevent fetching out of bounds data when sizing a column

glideapps · Aug 1, 2022 · c999082 · c999082
1 parent c3d2bc1
commit c999082
Showing 1 changed file with 11 additions and 2 deletions.
diff --git a/packages/core/src/data-editor/data-editor.tsx b/packages/core/src/data-editor/data-editor.tsx
@@ -1387,7 +1387,7 @@ const DataEditorImpl: React.ForwardRefRenderFunction<DataEditorRef, DataEditorPr
                         x: col,
                         y: start,
                         width: 1,
-                        height: end,
+                        height: Math.min(end, rows - start),
                     },
                     abortControllerRef.current.signal
                 );
@@ -1413,7 +1413,16 @@ const DataEditorImpl: React.ForwardRefRenderFunction<DataEditorRef, DataEditorPr
                 }
             }
         },
-        [columns, getCellsForSelection, maxColumnWidth, mergedTheme, minColumnWidth, onColumnResize, rowMarkerOffset]
+        [
+            columns,
+            getCellsForSelection,
+            maxColumnWidth,
+            mergedTheme,
+            minColumnWidth,
+            onColumnResize,
+            rowMarkerOffset,
+            rows,
+        ]
     );
 
     const [scrollDir, setScrollDir] = React.useState<GridMouseEventArgs["scrollEdge"]>();