Enforce readonly mode for uri-cell (#892)

glideapps · Feb 2, 2024 · f30193b · f30193b
1 parent 3be3011
commit f30193b
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/packages/core/src/cells/uri-cell.tsx b/packages/core/src/cells/uri-cell.tsx
@@ -115,7 +115,10 @@ export const uriCellRenderer: InternalCellRenderer<UriCell> = {
         const { onChange, value, forceEditMode, validatedSelection } = p;
         return (
             <UriOverlayEditor
-                forceEditMode={forceEditMode || (cell.hoverEffect === true && cell.onClickUri !== undefined)}
+                forceEditMode={
+                    value.readonly !== true &&
+                    (forceEditMode || (cell.hoverEffect === true && cell.onClickUri !== undefined))
+                }
                 uri={value.data}
                 preview={value.displayData ?? value.data}
                 validatedSelection={validatedSelection}

diff --git a/packages/core/src/internal/data-grid-overlay-editor/private/uri-overlay-editor.tsx b/packages/core/src/internal/data-grid-overlay-editor/private/uri-overlay-editor.tsx
@@ -16,7 +16,7 @@ interface Props {
 const UriOverlayEditor: React.FunctionComponent<Props> = p => {
     const { uri, onChange, forceEditMode, readonly, validatedSelection, preview } = p;
 
-    const [editMode, setEditMode] = React.useState<boolean>(uri === "" || forceEditMode);
+    const [editMode, setEditMode] = React.useState<boolean>(!readonly && (uri === "" || forceEditMode));
 
     const onEditClick = React.useCallback(() => {
         setEditMode(true);