Fix autoscroll bugs that cause wonkly behaviors #835
Conversation
jassmith
requested review from
BrianHung and
LukasMasuch
and removed request for
BrianHung
| @@ -515,7 +515,7 @@ const DataGrid: React.ForwardRefRenderFunction<DataGridRef, DataGridProps> = (p, | |||
| const isTouch = (ev !== undefined && !(ev instanceof MouseEvent)) || (ev as any)?.pointerType === "touch"; | |||
|
|
|||
| const scrollEdge: GridMouseEventArgs["scrollEdge"] = [ | |||
| x < stickyX ? -1 : rect.width < x ? 1 : 0, | |||
| x < 0 ? -1 : rect.width < x ? 1 : 0, | |||
There was a problem hiding this comment.
Ideally this would know if the current selection is inside the freeze region or not, but since this is not currently known in this region of the code I didn't want to plumb it through. We could then conditionally scroll. For now however this will have to do.
There was a problem hiding this comment.
What would be the benefit if we would know the freeze region here? Are there any problematic scenarios with just doing x < 0?
There was a problem hiding this comment.
Good catch. I initially used stickyX since I wanted autoscroll to occur when the cursor is over the rowMarkers, similar to how it vertically scrolls if you're in the column headers.
But yeah, stickyX isn't the right prop for it since it's dependent on fixedShadowX = true.
There was a problem hiding this comment.
The problematic scenario here is that with x < 0 you don't get autoscroll until you rmouse leaves the grid entirely. Ideally auto-scroll would start if you go over a sticky column and the current selected cell is not in the sticky region.
| @@ -515,7 +515,7 @@ const DataGrid: React.ForwardRefRenderFunction<DataGridRef, DataGridProps> = (p, | |||
| const isTouch = (ev !== undefined && !(ev instanceof MouseEvent)) || (ev as any)?.pointerType === "touch"; | |||
|
|
|||
| const scrollEdge: GridMouseEventArgs["scrollEdge"] = [ | |||
| x < stickyX ? -1 : rect.width < x ? 1 : 0, | |||
| x < 0 ? -1 : rect.width < x ? 1 : 0, | |||
There was a problem hiding this comment.
What would be the benefit if we would know the freeze region here? Are there any problematic scenarios with just doing x < 0?
| @@ -515,7 +515,7 @@ const DataGrid: React.ForwardRefRenderFunction<DataGridRef, DataGridProps> = (p, | |||
| const isTouch = (ev !== undefined && !(ev instanceof MouseEvent)) || (ev as any)?.pointerType === "touch"; | |||
|
|
|||
| const scrollEdge: GridMouseEventArgs["scrollEdge"] = [ | |||
| x < stickyX ? -1 : rect.width < x ? 1 : 0, | |||
| x < 0 ? -1 : rect.width < x ? 1 : 0, | |||
There was a problem hiding this comment.
Good catch. I initially used stickyX since I wanted autoscroll to occur when the cursor is over the rowMarkers, similar to how it vertically scrolls if you're in the column headers.
But yeah, stickyX isn't the right prop for it since it's dependent on fixedShadowX = true.
No description provided.