Fix row theme and column theme cutting off when entering into blank region of Grid #880
Conversation
| @@ -159,7 +160,11 @@ export function mergeAndRealizeTheme(theme: Theme, ...overlays: Partial<Theme | | |||
| for (const key in overlay) { | |||
| // eslint-disable-next-line no-prototype-builtins | |||
| if (overlay.hasOwnProperty(key)) { | |||
| merged[key] = (overlay as any)[key]; | |||
| if (key === "bgCell") { | |||
| merged[key] = blend(overlay[key] as string, merged[key]); | |||
There was a problem hiding this comment.
Without doing this we retain the previous requirement that bgCell always be a solid color. Now only the main theme need be a solid color.
| } | ||
| } | ||
| onCellEdited={setCellValue} | ||
| onColumnResize={onColumnResize} | ||
| rows={1_000_000} | ||
| rows={10} |
There was a problem hiding this comment.
This makes it easier to see the change
| ctx.beginPath(); | ||
| // render in reverse order because we computed and added the columns last, but they should actually be lower | ||
| // priority than the rows. | ||
| for (let i = toDraw.length - 1; i >= 0; i--) { |
There was a problem hiding this comment.
The complexity here is just to reduce the number of draw calls. Fewer draw calls === faster
Seems to be a missing row when trailingRowOptions and onRowAppended are defined. |
| } | ||
|
|
||
| y += rh; | ||
| if (row < rows) y2 = y; |
There was a problem hiding this comment.
This should perhaps be
if (row < rows - freezeTrailingRows) y2 = y;since drawing of column overflow should start at the last row with data.
There was a problem hiding this comment.
Would also change y2 to be a more descriptive variable like lastRowY or extraRowStartY.
There was a problem hiding this comment.
Thank you! Great catch.
|
LGTM after that fix :) |
Previously everything below the last data row would just be white