Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme options for edit hover indicators #926

Merged
merged 3 commits into from Mar 18, 2024

Conversation

ivoelbert
Copy link
Contributor

Screen.Recording.2024-03-18.at.12.01.20.PM.mov

This PR adds the hover effect for the number cell and adds some theming capabilities for it:

  • fullSize - don't adapt to the cell's size, use the cell's padding.
  • bgColor - the background color, defaults to the existing "darkText with opacity"

found TODOs:

  • number cell editor does not fit the cell as the text one.

@ivoelbert ivoelbert requested a review from jassmith March 18, 2024 15:08
@ivoelbert ivoelbert self-assigned this Mar 18, 2024
@jassmith jassmith merged commit bdffd4c into main Mar 18, 2024
7 checks passed
@jassmith jassmith deleted the ie/better_edit_hover_indicators branch March 18, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants