refactor: update fetch import for node v21+ compatibility #2573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use global fetch first, fallback to cross-fetch if needed - Addresses deprecation warnings due to unresolved issues in cross-fetch, node-fetch, and whatwg-url libraries - Ensures compatibility with environments running node.js v21+ where punycode module is deprecated
|
Thank you! Warnings be gone! |
inferrinizzard
added a commit
to inferrinizzard/quicktype
that referenced
this pull request
Apr 28, 2024
…ideapps#2573)" This reverts commit 8d4169b.
1 task
inferrinizzard
added a commit
to inferrinizzard/quicktype
that referenced
this pull request
Apr 28, 2024
…lity (glideapps#2573)"" This reverts commit df1321d.
dvdsgl
pushed a commit
that referenced
this pull request
Apr 28, 2024
* cast response.body to node readable stream for url fetch * add comment * Revert "refactor: update fetch import for node v21+ compatibility (#2573)" This reverts commit 8d4169b. * Revert "Revert "refactor: update fetch import for node v21+ compatibility (#2573)"" This reverts commit df1321d. * add FIXME comment * only use cross-fetch in CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
I've been following those issues on node-fetch node-fetch/node-fetch#1793
And on cross-fetch lquixada/cross-fetch#177
Both seems stale, so I hope that we can fix
quicktype-corein the meantime. I've used the solution recommended into thecross-fetchissue toward conditional import and using native node fetch if available.Motivation and Context
We're using
quicktype-corein some of our tools, one of them being a cli tool, every-time a command is ran the deprecation coming fromquicktype-codecross-fetchdependency shows up on node >=v21.Previous Behaviour / Output
New Behaviour / Output
No warning output.
How Has This Been Tested?
quicktype-corepackage locally with the changequicktype-coredependency to point to the local builded packagetgzand installFetchingJSONSchemaStorein node scripts to trigger the fetch behaviour with node versions16.20.1,18.20.2and21.7.3v16.20.2,v18.20.2,v21.7.3expected behaviour occurs and the warning is gone.Screenshots (if appropriate):