Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small improvements #328

Merged
merged 7 commits into from
Jul 22, 2019
Merged

Small improvements #328

merged 7 commits into from
Jul 22, 2019

Conversation

omares
Copy link
Contributor

@omares omares commented Mar 19, 2019

@jedrzejchalubek Please review :)

@webunderconstruction
Copy link

Nice work @omares, any idea when it will be merged in?

@jedrzejchalubek
Copy link
Member

@webunderconstruction I will get into this PR right after we merge #327. Both of these features will be released with v3.4.0 :)

@jedrzejchalubek jedrzejchalubek added this to the 3.4.0 milestone May 6, 2019
@omares omares mentioned this pull request Jun 3, 2019
1 task
@jedrzejchalubek jedrzejchalubek modified the milestones: 3.4.0, 4.0.0 Jul 7, 2019
@jedrzejchalubek jedrzejchalubek merged commit 30978df into glidejs:master Jul 22, 2019
@jedrzejchalubek
Copy link
Member

Great 💯Thanks!

@marcosmyara
Copy link

Hi @omares i'm pretty sure @jedrzejchalubek didnt commit these changes in the new version of the script. I made the changes to "controls.js" like you suggested, but now i'm supposed to rebuild the glide.js bundle again, apparently using webpack or something. I had no idea what that was until i did some research but still i am completely lost in regards to using it (i'm a long way from having a good understanding of programming). could you please provide me a version of the script already updated so the control arrows (enable/disable) work as they're expected to, or maybe guide me in the right direction? thank you.

@omares
Copy link
Contributor Author

omares commented Jan 17, 2020

My branch contains the updated distribution files. You can find them here https://github.com/omares/glide/tree/consolidated/dist
Please keep in mind the branch is outdated and does not contain changes that have been applied upstream

Also generating the compiled files is fairly easy. Running npm install and then npm run build should do the trick. Assuming you have npm/node installed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants