-
-
Notifications
You must be signed in to change notification settings - Fork 768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small improvements #328
Small improvements #328
Conversation
Nice work @omares, any idea when it will be merged in? |
@webunderconstruction I will get into this PR right after we merge #327. Both of these features will be released with v3.4.0 :) |
Great 💯Thanks! |
Hi @omares i'm pretty sure @jedrzejchalubek didnt commit these changes in the new version of the script. I made the changes to "controls.js" like you suggested, but now i'm supposed to rebuild the glide.js bundle again, apparently using webpack or something. I had no idea what that was until i did some research but still i am completely lost in regards to using it (i'm a long way from having a good understanding of programming). could you please provide me a version of the script already updated so the control arrows (enable/disable) work as they're expected to, or maybe guide me in the right direction? thank you. |
My branch contains the updated distribution files. You can find them here https://github.com/omares/glide/tree/consolidated/dist Also generating the compiled files is fairly easy. Running |
@jedrzejchalubek Please review :)