Skip to content

Commit

Permalink
Update Dockerfile
Browse files Browse the repository at this point in the history
  • Loading branch information
@digitalkaoz
digitalkaoz committed Jun 6, 2016
1 parent a923387 commit ff57c7d
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions Dockerfile
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,6 @@ EXPOSE 80
COPY . /src
RUN cd /src && ./build.sh "$(cat VERSION)"

ONBUILD COPY ./build.sh /src/build.sh
ONBUILD COPY ./modules.go /src/modules.go
ONBUILD RUN cd /src && ./build.sh "$(cat VERSION)-custom"

5 comments on commit ff57c7d

@dsaita
Copy link

@dsaita dsaita commented on ff57c7d Jul 21, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks when I try to customize the image.
This requires that I have a build.sh file with the same contents as the original.

@josegonzalez
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull requests welcome.

@dsaita
Copy link

@dsaita dsaita commented on ff57c7d Jul 21, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am sorry, I don't know how to fix it, but tag v3.1 still works so that's good.

@josegonzalez
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well can you at least open up an issue so that we can track it?

@digitalkaoz
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dsaita mh it worked here, even without the build.sh

Please sign in to comment.