feat(consul,service_tags): Support escaped comma

[samber]

#390

Example:

docker run -d \
      -p 4242:4242 \
      -e 'SERVICE_4242_TAGS=traefik.frontend.rule=Host: www.example.com\, Path: /api,traefik.enable=true' \
      company/service

Create only 2 tags into consul:

• traefik.frontend.rule=Host: www.example.com, Path: /api
• traefik.enable=true

[josegonzalez]

I'm not sure about this code, mostly because there are no tests for this utility file and this seems like a good candidate for tests. @samber Mind adding tests? Once you do, I can totally merge this in for the next release :)

[samber]

Done ;-)

Please note #439

[jakew]

Is there an ETA on when this would actually be merged or released? I look forward to this for using Traefik.

[josegonzalez]

@jakew no ETA at the moment. I'm not sure anyone knows how to make a release of registrator at the moment, which I'm trying to sort out (amongst other things).

[bweston92]

Any update? I want to switch to Traefik and keep using this nice bit of kit :D

[Kemyke]

This issue makes the registrator useless if you try to use it with traefik. Can somebody merge the PR? Its a quite small change and it is waiting for 6 months. Or should we consider this project dead and try to fix it ourselfs?

[ViViDboarder]

FYI for anyone affected by this: I just spent a while debugging issues with this and realized it's been merged but it's not part of the latest tag on Docker Hub.

https://hub.docker.com/r/gliderlabs/registrator/tags/

Make sure you're using gliderlabs/registrator:master.

[saurabhguptag]

could you please push this to "latest" tag do not want to use master image

[josegonzalez]

@saurabhguptag We'll get to it when we get to it.