Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build error #112

Merged
merged 1 commit into from
Jun 19, 2019
Merged

Fix build error #112

merged 1 commit into from
Jun 19, 2019

Conversation

gustavosbarreto
Copy link
Collaborator

DefaultServerConfigCallback was renamed to ServerConfigCallback

@gustavosbarreto
Copy link
Collaborator Author

I don't understanding why build fails in golang:master

@gustavosbarreto
Copy link
Collaborator Author

This works for me:

docker pull golang:master
docker run -v $PWD:/go/src/github.com/gliderlabs/ssh -w /go/src/github.com/gliderlabs/ssh golang:latest sh -c 'go get; go test -v -race'

@belak
Copy link
Collaborator

belak commented Jun 19, 2019

Ahh, crap. I thought I ran tests before merging. Thanks for this.

@belak belak merged commit 93eb073 into gliderlabs:master Jun 19, 2019
@root360-StefanHeitmueller root360-StefanHeitmueller mentioned this pull request Jan 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gustavosbarreto @belak