Passes Context into ConnCallback #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe by convention the context is passed in as the first argument, otherwise, looks good to go! |
Michael9127
force-pushed
the
pass-ConnCallback-context
branch
from
bbaf8bb
to
e9ac9d7
Compare
|
fixed, thanks! |
|
Awesome! Thanks! This is a breaking change so the first tagged version to have this will probably be 0.3. |
|
@belak would you mind tagging this as 0.3? |
|
Yep, done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves context creation before the ConnCallback invocation and passes it into the callback. Allowing state to be set for the duration of the connection.