Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add way to fetch the unparsed command string from a session. #93

Closed
wants to merge 1 commit into from

Conversation

andrewchambers
Copy link
Contributor

No description provided.

@progrium
Copy link
Contributor

As reasonable as this is, what do other people think about this? You can basically get this by rejoining the split command string. I'm curious, @andrewchambers what is the use case for this? I suspected the common case would be like you're using os.Args and nobody has requested something like this until now.

@andrewchambers
Copy link
Contributor Author

andrewchambers commented Jan 24, 2019

I am forwarding to another ssh server, and letting it handle the command exactly as it was sent (things like) FOO=bar command

I didn't trust shlex+join to preserve all bash semantics, even though perhaps it might, I couldn't guarantee it, so did this to ensure it works in every case.

@belak
Copy link
Collaborator

belak commented Jun 12, 2019

At my old job I would have been looking for this as well - there was some custom parsing we wanted to do with the commands that wasn't possible when it came through shlex

@belak
Copy link
Collaborator

belak commented Jul 17, 2020

This was merged as a part of #110. Thanks for submitting this!

@belak belak closed this Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants