Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates for the Node app #243

Merged
merged 15 commits into from
Apr 1, 2022
Merged

Updates for the Node app #243

merged 15 commits into from
Apr 1, 2022

Conversation

navFooh
Copy link
Contributor

@navFooh navFooh commented Mar 31, 2022 •
edited
Loading

Ready to merge

@navFooh navFooh requested a review from Schwartz10 March 31, 2022 22:55
@navFooh navFooh marked this pull request as ready for review April 1, 2022 14:16
@navFooh navFooh mentioned this pull request Apr 1, 2022
Merged
Schwartz10
Schwartz10 reviewed Apr 1, 2022
View reviewed changes
Copy link
Contributor

@Schwartz10 Schwartz10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine for me, just wondering about the change in implementation of IconWarn

src/components/Icons/index.tsx Show resolved Hide resolved
@Schwartz10 Schwartz10 merged commit fa8d33f into primary Apr 1, 2022
@Schwartz10 Schwartz10 deleted the node-updates branch April 1, 2022 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Schwartz10 Schwartz10 Schwartz10 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@navFooh @Schwartz10