This repository has been archived by the owner on Jan 18, 2021. It is now read-only.
Add glimmer-component and glimmer-helper blueprints #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enables us to use "ember generate glimmer-component foo-bar" in projects that depend on "glimmer-application-pipeline"
Turbo87
reviewed
Mar 28, 2017
| @@ -0,0 +1,2 @@ | |||
| export default function(params) { | |||
There was a problem hiding this comment.
shouldn't that be in src/ui/helpers?
There was a problem hiding this comment.
and since components have a class name now, shouldn't helper functions have one too?
There was a problem hiding this comment.
shouldn't that be in src/ui/helpers?
We debated this for a while coming up with module unification, and settled on helpers and components in the same collection of invocable template functions.
There was a problem hiding this comment.
and since components have a class name now, shouldn't helper functions have one too?
Probably - sorry I was in a rush.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on @Turbo87's work in #24, this adds new blueprints for both glimmer components and helpers.
After ember-cli-legacy-helpers is removed from ember-cli, we should plan to support plain
componentandhelperblueprints here (since they won't conflict with the legacy blueprints).