Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toggle Visibility of Components and Helpers #14

Merged
merged 1 commit into from
Jan 12, 2018
Merged

Toggle Visibility of Components and Helpers #14

merged 1 commit into from
Jan 12, 2018

Conversation

nummi
Copy link
Contributor

@nummi nummi commented Dec 6, 2017

@locks
Copy link
Contributor

locks commented Jan 12, 2018

Sorry, this dropped off of my radar! Looks great :)

@locks locks merged commit fb79ab7 into glimmerjs:master Jan 12, 2018
@knownasilya
Copy link

knownasilya commented Jan 12, 2018 •
edited

Kinda late, but a couple comments:

  • Clicking the arrow twice selects the text of that component. Maybe using user-select: none?
  • Would be nice to click the whole header, not just the tiny icon

@locks
Copy link
Contributor

locks commented Jan 12, 2018

Can you open an issue pliz?

@knownasilya knownasilya mentioned this pull request Jan 12, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nummi @locks @knownasilya