-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot build in Node >= 8.3.0 #19
Comments
So I spent a bit of time looking into this and the reason why the stackFrame.getFileName() is null is because that stack frame is actually an anonymous Array.map() so theoretically it doesn't have a file name 😕 I don't know what the desired behaviour is but maybe we should continue looping through the stack until we come across a file? Again I'm not entirely sure what the use case is. This is the first few lines of the stack at that point:
I'm assuming the desired stack line would be: |
btw this test passes if I manually change the index here https://github.com/glimmerjs/glimmer-build/blob/master/lib/resolve-package.js#L15 to 5, which would point at the stack item: |
In Node 8.2.1 I can build the resolve, in 8.3.0 and greater I get a failure ala:
I spent some time debugging this and it seams the return value from
getFileName
here is sometimesnull
. I tried to add a reproduction test on https://github.com/glimmerjs/glimmer-build but failed.Refs: glimmerjs/glimmer-build#49
The text was updated successfully, but these errors were encountered: