Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@glimmer/syntax] Partial support #948

Closed
AndrewLeedham opened this issue Jun 13, 2019 · 5 comments
Closed

[@glimmer/syntax] Partial support #948

AndrewLeedham opened this issue Jun 13, 2019 · 5 comments

Comments

@AndrewLeedham
Copy link

AndrewLeedham commented Jun 13, 2019

I noticed an error is thrown if a partial is found in a HBS file when parsing it with @glimmer/syntax. I can't find any documentation as to why it is not supported. Is this something that may come in the future, or is there a technical reason Partials aren't supported?

@lifeart
Copy link
Contributor

lifeart commented Jun 18, 2019

@AndrewLeedham
Copy link
Author

Thanks @lifeart. For context I am trying to figure out a way of adding partial support to https://github.com/danakt/handlebars-to-jsx which currently uses @glimmer/syntax to create an AST.

@lifeart
Copy link
Contributor

lifeart commented Jun 19, 2019

How partials will look like in jsx output?
Easy way - replace {{partial..}} before transform to {{jsx-partial..}} and align final output

Copy link
Member

rwjblue commented Jun 19, 2019

@lifeart I suspect that @AndrewLeedham is referring to the handlebars partial syntax, not Ember's {{partial.

@AndrewLeedham - In general, @glimmer/syntax is specifically supporting Ember's style of Handlebars and as such we specifically error for syntax in Handlebars that Ember doesn't support.

@AndrewLeedham
Copy link
Author

@rwjblue You are correct I am looking for both {{> and {{#> partial support. Seems like @glimmer/syntax isn't the right tool for the job. Thanks for your help 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants