Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix evaluation stack off-by-one error introduced in #1293 #1297

Merged
merged 1 commit into from
Apr 22, 2021
Merged

Fix evaluation stack off-by-one error introduced in #1293 #1297

merged 1 commit into from
Apr 22, 2021

Commits on Apr 22, 2021

  1. Fix evaluation stack off-by-one error introduced in #1293 

    Before #1293, the `Load` operation would have popped the helper
definition off of the evalution stack. After the #1293, nothing is
popping it off anymore and that creates problem downstream.

This balances things out by inserting a `Pop(1)` in the original
frame.

I couldn't think of a good way to test this, and this is blocking
Ember beta, so we will merge this now (Ember has a test confirming
this works) and @pzuraq will add a test later.
    @chancancode
    chancancode committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    821b9dc View commit details
    Browse the repository at this point in the history