-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate references and tags #1314
Open
pzuraq
wants to merge
9
commits into
main
Choose a base branch
from
consolidate-references-and-tags
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on May 22, 2021
-
Upstreams the @Tracked decorator, making it part of the @glimmer/validator package, and removing the `trackedData` concept. The original concept did not really pan out and was used almost exclusively for @Tracked. This change will make it easier to refactor and consolidate the various tag/tracking concepts.
Chris Garrett committedMay 22, 2021 Configuration menu - View commit details
-
Copy full SHA for 38f06d1 - Browse repository at this point
Copy the full SHA 38f06d1View commit details -
Makes modifiers and didCreate/didUpdate cache driven
This PR finishes up the autotracking refactors that were done previously, making after-render effects that used to be handled by the render transaction handled instead by an EffectsManager. The EffectsManager essentially manages a number of caches, which it keeps in lists internally. Every time a render completes, these queues are scheduled to run, with every cache in the queue being checked in order to see if something has changed. If it has, the effect runs its update. The biggest change with this refactor is that the `didCreate`/`didUpdate` hooks used by classic components will now interleave with modifiers. Previously, they always ran _before_ all modifiers, regardless of whether the modifiers were children of a given component. In theory, this shouldn't be an issue, but if it is we can separate out the component hooks into a separate queue and restore the prevous ordering.
Chris Garrett committedMay 22, 2021 Configuration menu - View commit details
-
Copy full SHA for 2b75b2d - Browse repository at this point
Copy the full SHA 2b75b2dView commit details -
Chris Garrett committed
May 22, 2021 Configuration menu - View commit details
-
Copy full SHA for dc3bfc5 - Browse repository at this point
Copy the full SHA dc3bfc5View commit details -
Chris Garrett committed
May 22, 2021 Configuration menu - View commit details
-
Copy full SHA for 9ed99b3 - Browse repository at this point
Copy the full SHA 9ed99b3View commit details
Commits on May 23, 2021
-
Chris Garrett committed
May 23, 2021 Configuration menu - View commit details
-
Copy full SHA for f322488 - Browse repository at this point
Copy the full SHA f322488View commit details -
Chris Garrett committed
May 23, 2021 Configuration menu - View commit details
-
Copy full SHA for 3a6fc0c - Browse repository at this point
Copy the full SHA 3a6fc0cView commit details -
Chris Garrett committed
May 23, 2021 Configuration menu - View commit details
-
Copy full SHA for c851e14 - Browse repository at this point
Copy the full SHA c851e14View commit details -
try using fields instead of weakmaps
Chris Garrett committedMay 23, 2021 Configuration menu - View commit details
-
Copy full SHA for aedfc2c - Browse repository at this point
Copy the full SHA aedfc2cView commit details -
make sure lastRevision cache works
Chris Garrett committedMay 23, 2021 Configuration menu - View commit details
-
Copy full SHA for 676a4b6 - Browse repository at this point
Copy the full SHA 676a4b6View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.