Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate references and tags #1314

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Commits on May 22, 2021

  1. Upstream @Tracked

    Upstreams the @Tracked decorator, making it part of the
    @glimmer/validator package, and removing the `trackedData` concept. The
    original concept did not really pan out and was used almost exclusively
    for @Tracked. This change will make it easier to refactor and
    consolidate the various tag/tracking concepts.
    Chris Garrett committed May 22, 2021
    Configuration menu
    Copy the full SHA
    38f06d1 View commit details
    Browse the repository at this point in the history
  2. Makes modifiers and didCreate/didUpdate cache driven

    This PR finishes up the autotracking refactors that were done
    previously, making after-render effects that used to be handled by the
    render transaction handled instead by an EffectsManager. The
    EffectsManager essentially manages a number of caches, which it keeps
    in lists internally. Every time a render completes, these queues are
    scheduled to run, with every cache in the queue being checked in order
    to see if something has changed. If it has, the effect runs its update.
    
    The biggest change with this refactor is that the
    `didCreate`/`didUpdate` hooks used by classic components will now
    interleave with modifiers. Previously, they always ran _before_ all
    modifiers, regardless of whether the modifiers were children of a given
    component. In theory, this shouldn't be an issue, but if it is we can
    separate out the component hooks into a separate queue and restore the
    prevous ordering.
    Chris Garrett committed May 22, 2021
    Configuration menu
    Copy the full SHA
    2b75b2d View commit details
    Browse the repository at this point in the history
  3. wip

    Chris Garrett committed May 22, 2021
    Configuration menu
    Copy the full SHA
    dc3bfc5 View commit details
    Browse the repository at this point in the history
  4. wip

    Chris Garrett committed May 22, 2021
    Configuration menu
    Copy the full SHA
    9ed99b3 View commit details
    Browse the repository at this point in the history

Commits on May 23, 2021

  1. wip

    Chris Garrett committed May 23, 2021
    Configuration menu
    Copy the full SHA
    f322488 View commit details
    Browse the repository at this point in the history
  2. wip

    Chris Garrett committed May 23, 2021
    Configuration menu
    Copy the full SHA
    3a6fc0c View commit details
    Browse the repository at this point in the history
  3. wip

    Chris Garrett committed May 23, 2021
    Configuration menu
    Copy the full SHA
    c851e14 View commit details
    Browse the repository at this point in the history
  4. try using fields instead of weakmaps

    Chris Garrett committed May 23, 2021
    Configuration menu
    Copy the full SHA
    aedfc2c View commit details
    Browse the repository at this point in the history
  5. make sure lastRevision cache works

    Chris Garrett committed May 23, 2021
    Configuration menu
    Copy the full SHA
    676a4b6 View commit details
    Browse the repository at this point in the history