Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix another issue with getTemplateLocals and block params #1412

Merged

Conversation

NullVoxPopuli
Copy link
Contributor

@NullVoxPopuli NullVoxPopuli commented Mar 27, 2023

This one stems from ElementNode not having a parsed tag name -- it's just a string, instead of potentially a PathExpression, like it would/should be in the case of:

<Wrapper as |w|>
    <w.button />
{{! ^ ElementNode
     ^ PathExpression { parts: ['w', 'button' ] }
}}

</Wrapper>

@NullVoxPopuli NullVoxPopuli force-pushed the fix-more-getTemplateLocalsBugs branch from ef14db4 to 79eb370 Compare May 3, 2023 01:47
@wycats wycats self-assigned this May 3, 2023
Copy link
Contributor

@wycats wycats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

I want to update this code to use ASTv2, which doesn't have any of these issues, but this is fine as an interim measure.

@wycats wycats merged commit bdcb792 into glimmerjs:master May 3, 2023
8 checks passed
@NullVoxPopuli NullVoxPopuli deleted the fix-more-getTemplateLocalsBugs branch May 3, 2023 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants