Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Yarn failure + other updates #109

Merged
merged 3 commits into from Feb 6, 2018
Merged

Fix Yarn failure + other updates #109

merged 3 commits into from Feb 6, 2018

Conversation

tomdale
Copy link
Contributor

@tomdale tomdale commented Feb 6, 2018

This PR:

  1. Removes the yarn.lock file so app creation doesn't fail out of the gate.
  2. Updates @glimmer/application-pipeline to 0.10.
  3. Updates TypeScript to 2.6, and replaces the ^ operator in package.json with a ~ because TypeScript doesn't follow SemVer.
  4. Removes ember-cli-sass by default.

(Originally submitted as glimmerjs/glimmer-blueprint#79.)

Ember CLI detects the yarn.lock file to decide whether to use Yarn or not. Pending yarnpkg/yarn#5059, we should switch to npm by default.
This package has a dependency on node-sass, which means creating a new app takes a really long time while it compiles libsass. This is a poor first impression for us to make, especially because we hide the fact that it's libsass compiling.
This version fixes some compatibility issues with TypeScript
@chadhietala chadhietala merged commit c7d9e5a into master Feb 6, 2018
@chadhietala chadhietala deleted the fix-yarn-failure branch February 6, 2018 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants