-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix ci #379
Merged
chancancode
merged 22 commits into
glimmerjs:master
from
NullVoxPopuli:fix-ci-34f8a7e7ps
Feb 24, 2022
Merged
fix ci #379
Changes from 19 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
9f9e796
Drop support for Ember < 3.24
NullVoxPopuli 4ad7555
Add webpack and ember-auto-import@2 to glimmer/component and update t…
NullVoxPopuli 5aae2cc
Upgrade some dependencies in @glimmer/component used for testing
NullVoxPopuli 3b872ab
Update testem configs
NullVoxPopuli 6e1db8e
Sync dependencies with the 3.24 blueprint
NullVoxPopuli 0d3d7fb
Upgrade node / volta config
NullVoxPopuli 4453191
Lint fix
NullVoxPopuli 1ecf676
types pass now
NullVoxPopuli b7f8737
Add optional features
NullVoxPopuli 53ff239
Add optional features
NullVoxPopuli 1b2d56e
Update babel fixtures
NullVoxPopuli 137dd4f
Scope isn't present when not set
NullVoxPopuli 25d5384
Upgrade qunit setup for @glimmer/component
NullVoxPopuli d519bfc
More modernization
NullVoxPopuli a5010ac
Add embroider/test-setup
NullVoxPopuli 5b0c54f
Migrate to @ember/destroyable and avoid the Ember global
NullVoxPopuli 12b2a76
Re-roll lockfile
NullVoxPopuli 2fcd697
Upgrade ember-cli
NullVoxPopuli e757dc0
Ember-cli 3.27 is the max version I can use without running in to: ht…
NullVoxPopuli 6e3ba54
Re-add ember 3.12 and 3.16 to glimmer/component try-scenarios
NullVoxPopuli fe0d39d
Re-remove support for 3.16 and 3.12 because there is *no way* they ac…
NullVoxPopuli 60b5237
Place optional-features in the place where ember test expects them to be
NullVoxPopuli File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
{ | ||
"application-template-wrapper": false, | ||
"default-async-observers": true, | ||
"jquery-integration": false, | ||
"template-only-glimmer-components": true | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 4 additions & 1 deletion
5
packages/@glimmer/component/test/ember/dummy/config/optional-features.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,6 @@ | ||
{ | ||
"jquery-integration": false | ||
"application-template-wrapper": false, | ||
"default-async-observers": true, | ||
"jquery-integration": false, | ||
"template-only-glimmer-components": true | ||
} |
Empty file.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
...ages/@glimmer/component/test/ember/integration/components/glimmer-component-guide-test.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was dropping support tied to the requirements for the
@cached
decorator, or is it just because/part of the blueprint update? (i.e. are we able to keep the older Ember versions if we wanted to?)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can give it a go -- I was mainly going with the ember support policy, cause I don't know what the glimmer one is
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i guess it's fine 🙃
(assuming we trust the tests)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I wasn't implying that we should do it one way or the other, just wanted to know if it was deliberate/required or out of convince (what could be fine). Although, now that you proved that it works (at least according to the tests), if it doesn't end up hurting anything, I personally would be inclined to keep the support to aid adoption (though we should also include 3.20 in the matrix in that case).
However, I do think it is important to double check and make sure we in fact could support the
@cached
decorator on all of these versions, at least before we release 2.0 final.