-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Support for Emoji Reactions (Replaces #1980) #2127
Commits on May 7, 2023
-
add backend support for status emoji reactions
turns out we can just reuse the code for announcement reactions.
Configuration menu - View commit details
-
Copy full SHA for 9fccc8c - Browse repository at this point
Copy the full SHA 9fccc8cView commit details -
add frontend for emoji reactions
this is still pretty bare bones but hey, it works.
Configuration menu - View commit details
-
Copy full SHA for 671fb4c - Browse repository at this point
Copy the full SHA 671fb4cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 56cb7ff - Browse repository at this point
Copy the full SHA 56cb7ffView commit details -
this is kind of experimental, but it should work in theory. at least i tested it with a remove akkoma instance and it didn't crash.
Configuration menu - View commit details
-
Copy full SHA for a1685c4 - Browse repository at this point
Copy the full SHA a1685c4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6646d36 - Browse repository at this point
Copy the full SHA 6646d36View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4f4237c - Browse repository at this point
Copy the full SHA 4f4237cView commit details -
make frontend fetch reaction limit
the maximum number of reactions was previously hardcoded to 8. this commit also fixes an incorrect query in StatusReactionValidator where it didn't count per-user reactions but the total amount of different ones.
Configuration menu - View commit details
-
Copy full SHA for 6bd0646 - Browse repository at this point
Copy the full SHA 6bd0646View commit details -
Configuration menu - View commit details
-
Copy full SHA for f61c649 - Browse repository at this point
Copy the full SHA f61c649View commit details -
Configuration menu - View commit details
-
Copy full SHA for c96110a - Browse repository at this point
Copy the full SHA c96110aView commit details -
handle misskey reactions properly
misskey federates emoji reactions as likes.
Configuration menu - View commit details
-
Copy full SHA for 256a07e - Browse repository at this point
Copy the full SHA 256a07eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0ae702a - Browse repository at this point
Copy the full SHA 0ae702aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9868231 - Browse repository at this point
Copy the full SHA 9868231View commit details -
Configuration menu - View commit details
-
Copy full SHA for 299b501 - Browse repository at this point
Copy the full SHA 299b501View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4951abe - Browse repository at this point
Copy the full SHA 4951abeView commit details -
limit number of reactions displayed
Too many reactions on a single post quickly get spammy, so they are now sorted by count and only the first MAX_REACTIONS number of different emojis are actually displayed.
Configuration menu - View commit details
-
Copy full SHA for 78e0e74 - Browse repository at this point
Copy the full SHA 78e0e74View commit details -
Configuration menu - View commit details
-
Copy full SHA for b6f8093 - Browse repository at this point
Copy the full SHA b6f8093View commit details -
make number of displayed reactions a setting
This adds an extra item to the local settings for specifying the number of reactions shown in toots. The detailed status view always shows all reactions.
Configuration menu - View commit details
-
Copy full SHA for c3a18c6 - Browse repository at this point
Copy the full SHA c3a18c6View commit details -
make number of visible reactions a vanilla setting
Reactions will be backported to the vanilla flavour, which requires all related settings to be accessible from the vanilla settings page rather than the glitch specific settings modal.
Configuration menu - View commit details
-
Copy full SHA for 573f12e - Browse repository at this point
Copy the full SHA 573f12eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7403e91 - Browse repository at this point
Copy the full SHA 7403e91View commit details -
Configuration menu - View commit details
-
Copy full SHA for 49c8048 - Browse repository at this point
Copy the full SHA 49c8048View commit details -
Configuration menu - View commit details
-
Copy full SHA for a8afee5 - Browse repository at this point
Copy the full SHA a8afee5View commit details -
fix reaction deletion bug and clean up controller
Turns out the strange error where it would delete the wrong reaction occurred because I forgot to pass the emoji name to the query, which resulted in the database deleting the first reaction it found. Also, this removes the unused set_reaction callback and includes the Authorization module for the status reactions controller.
Configuration menu - View commit details
-
Copy full SHA for 946debe - Browse repository at this point
Copy the full SHA 946debeView commit details -
change reaction api to match other interactions
Status reactions had an API similar to that of announcement reactions, using PUT and DELETE at a single endpoint. I believe that for statuses, it makes more sense to follow the convention of the other interactions and use separate POST endpoints for create and destroy respectively.
Configuration menu - View commit details
-
Copy full SHA for be710b6 - Browse repository at this point
Copy the full SHA be710b6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 490c1a2 - Browse repository at this point
Copy the full SHA 490c1a2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4452ddb - Browse repository at this point
Copy the full SHA 4452ddbView commit details -
rename nop handler to handleNoOp
This also adds the comment in action_bar.js to status_action_bar.js, clarifying that a future version could improve this code by modifying EmojiPickerDropdown.
Configuration menu - View commit details
-
Copy full SHA for 9f6a880 - Browse repository at this point
Copy the full SHA 9f6a880View commit details -
fix padding on posts without reactions
The margins of the elements above and below the main reaction list element overlapped before reactions were added. Adding display: none to empty reaction bars restores this exact look.
Configuration menu - View commit details
-
Copy full SHA for 8aadf99 - Browse repository at this point
Copy the full SHA 8aadf99View commit details -
Configuration menu - View commit details
-
Copy full SHA for d5ccf3b - Browse repository at this point
Copy the full SHA d5ccf3bView commit details -
sanitize setting for number of visible reactions
This is kind of a hack, but the lack of validation for settings unfortunately makes it necessary.
Configuration menu - View commit details
-
Copy full SHA for d820510 - Browse repository at this point
Copy the full SHA d820510View commit details -
download remote custom emojis from reactions
Emoji reactions containing custom emojis from remote instances were assumed to already have been downloaded and stored in the database. This might obviously not be the case.
Configuration menu - View commit details
-
Copy full SHA for 16e08e1 - Browse repository at this point
Copy the full SHA 16e08e1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7349a5a - Browse repository at this point
Copy the full SHA 7349a5aView commit details -
Configuration menu - View commit details
-
Copy full SHA for dbbfea1 - Browse repository at this point
Copy the full SHA dbbfea1View commit details -
display external custom emoji reactions properly
Using an emoji map was completely unnecessary in the first place, because the reaction list from the API response includes URLs for every custom emoji anyway. The reaction list now also contains a boolean field indicating whether it is an external custom emoji, which is required because people should only be able to react with Unicode emojis and local custom ones, not with custom emojis from other servers.
Configuration menu - View commit details
-
Copy full SHA for d0f3f64 - Browse repository at this point
Copy the full SHA d0f3f64View commit details -
Configuration menu - View commit details
-
Copy full SHA for eac272d - Browse repository at this point
Copy the full SHA eac272dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 799fb28 - Browse repository at this point
Copy the full SHA 799fb28View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6a1c438 - Browse repository at this point
Copy the full SHA 6a1c438View commit details -
Configuration menu - View commit details
-
Copy full SHA for 588315a - Browse repository at this point
Copy the full SHA 588315aView commit details -
serialize custom emoji reactions properly for AP
Akkoma and possibly others expect the `tag` field in an EmojiReact activity to be an array, not just a single object, so it's being wrapped into one now. I'm not entirely sure whether this is the idiomatic way of doing it tbh, but it works fine.
Configuration menu - View commit details
-
Copy full SHA for 13b5375 - Browse repository at this point
Copy the full SHA 13b5375View commit details -
Configuration menu - View commit details
-
Copy full SHA for f6b1ec0 - Browse repository at this point
Copy the full SHA f6b1ec0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3eab0d0 - Browse repository at this point
Copy the full SHA 3eab0d0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 215a76c - Browse repository at this point
Copy the full SHA 215a76cView commit details -
Configuration menu - View commit details
-
Copy full SHA for ed60e5b - Browse repository at this point
Copy the full SHA ed60e5bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4761bd3 - Browse repository at this point
Copy the full SHA 4761bd3View commit details -
fix 404 when reacting with Keycap Number Sign
The Unicode sequence for this emoji starts with an ASCII # character, which the browser's URI parser truncates before sending the request to the backend.
Configuration menu - View commit details
-
Copy full SHA for 79ff467 - Browse repository at this point
Copy the full SHA 79ff467View commit details -
Configuration menu - View commit details
-
Copy full SHA for 275a67b - Browse repository at this point
Copy the full SHA 275a67bView commit details -
Configuration menu - View commit details
-
Copy full SHA for b753263 - Browse repository at this point
Copy the full SHA b753263View commit details -
Configuration menu - View commit details
-
Copy full SHA for 49b25c5 - Browse repository at this point
Copy the full SHA 49b25c5View commit details -
Per PR suggestion, split name and domain, and look for emoji ID, for …
…unreact, so remote emoji's can be unreacted
Configuration menu - View commit details
-
Copy full SHA for 2664621 - Browse repository at this point
Copy the full SHA 2664621View commit details -
Configuration menu - View commit details
-
Copy full SHA for 98eab31 - Browse repository at this point
Copy the full SHA 98eab31View commit details -
Keep emoji picker within screen bounds
Adds the `flip` prop to `<Overlay>`. Fixes #40
Configuration menu - View commit details
-
Copy full SHA for b78ea8b - Browse repository at this point
Copy the full SHA b78ea8bView commit details -
Configuration menu - View commit details
-
Copy full SHA for f718c02 - Browse repository at this point
Copy the full SHA f718c02View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0c23022 - Browse repository at this point
Copy the full SHA 0c23022View commit details -
Configuration menu - View commit details
-
Copy full SHA for 34f9e54 - Browse repository at this point
Copy the full SHA 34f9e54View commit details -
Configuration menu - View commit details
-
Copy full SHA for 759a277 - Browse repository at this point
Copy the full SHA 759a277View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7d7eff8 - Browse repository at this point
Copy the full SHA 7d7eff8View commit details -
Configuration menu - View commit details
-
Copy full SHA for e0db7dc - Browse repository at this point
Copy the full SHA e0db7dcView commit details -
Configuration menu - View commit details
-
Copy full SHA for fa0a5a7 - Browse repository at this point
Copy the full SHA fa0a5a7View commit details -
Configuration menu - View commit details
-
Copy full SHA for b0b593d - Browse repository at this point
Copy the full SHA b0b593dView commit details -
Remove failing skip_before_action from v1/custom_emojis_controller.rb
Fixes incorrect merge at 9eb1494
Configuration menu - View commit details
-
Copy full SHA for ec687d7 - Browse repository at this point
Copy the full SHA ec687d7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4bd3c80 - Browse repository at this point
Copy the full SHA 4bd3c80View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2a8b66a - Browse repository at this point
Copy the full SHA 2a8b66aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 730878a - Browse repository at this point
Copy the full SHA 730878aView commit details -
Revert "Fix missed merge conflict text in version.rb"
This reverts commit 2a8b66a.
Configuration menu - View commit details
-
Copy full SHA for eb68f62 - Browse repository at this point
Copy the full SHA eb68f62View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5bd0c35 - Browse repository at this point
Copy the full SHA 5bd0c35View commit details -
Configuration menu - View commit details
-
Copy full SHA for f560ee4 - Browse repository at this point
Copy the full SHA f560ee4View commit details
Commits on May 8, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 924e858 - Browse repository at this point
Copy the full SHA 924e858View commit details