Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Issue ID lookup #151

Closed
rohitpaulk opened this issue Aug 6, 2014 · 5 comments
Closed

Improve Issue ID lookup #151

rohitpaulk opened this issue Aug 6, 2014 · 5 comments
Labels
enhancement good first bug in progress

Comments

@rohitpaulk
Copy link
Member

Currently, the Issue subIDs are found by searching an array of the project's issues IDs, sorting and then finding the position of a certain issue. It's likely to be faster if we store the issue subID in our database.

Here's a blogpost about this if you'd like to read more.
@EmilyDirsh
Copy link
Contributor

@rohitpaulk - is this still relevant? Just trying to clean up the issue tracker...

@rohitpaulk
Copy link
Member Author

It is relevant, yes. :)

@EmilyDirsh
Copy link
Contributor

Do we need to discuss it more, or are we just waiting on implementation?

@rohitpaulk
Copy link
Member Author

We discussed this over email long ago. From the blog post:

Add two more columns to your database. One for the sub_id on the issue model, and an increment counter on the project model.

@EmilyDirsh
Copy link
Contributor

@rohitpaulk - I'm thinking this might be a good first bug - what do you think?

@sarupbanskota sarupbanskota mentioned this issue Mar 18, 2015
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first bug in progress
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@EmilyDirsh @sarupbanskota @rohitpaulk