Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

events loop 2 alpha release? #1756

Closed
Lokathor opened this issue Jul 21, 2019 · 9 comments
Closed

events loop 2 alpha release? #1756

Lokathor opened this issue Jul 21, 2019 · 9 comments

Comments

@Lokathor
Copy link
Contributor

Can there be an alpha release of glium that bumps the glutin version to its alpha version, which in turn uses the winit 0.20-alpha version?

@est31
Copy link
Collaborator

est31 commented Jul 21, 2019

Sure, PRs are welcome!

@Lokathor
Copy link
Contributor Author

A simplistic attempt to bump the version leads to the following build error:

D:\dev\glium>cargo test
    Updating crates.io index
error: failed to select a version for `glutin`.
    ... required by package `glium v0.25.1-alpha1 (D:\dev\glium)`
versions that meet the requirements `^0.22.0-alpha1` are: 0.22.0-alpha1

the package `glium` depends on `glutin`, with features: `icon_loading` but `glutin` does not have these features.


failed to select a version for `glutin` which could resolve this conflict

It seems that one of the features that you're depending on has gone away. You'll have to decide how to handle that. Above my pay grade for a basic PR I'm afraid ;_;

@est31
Copy link
Collaborator

est31 commented Jul 21, 2019

For reference discussion about this is in rust-windowing/winit#799

I think you can just remove the icon_loading feature. While it's definitely non-trivial to upgrade glutin because it has some larger changes, help would very much be appreciated!

@Lokathor
Copy link
Contributor Author

The glutin alpha release is already out and using the new winit 0.20 alpha, so if glium can just drop that feature then that simplifies things I think.

I ended up going ahead and starting on a gfx-hal based project, so I think it's unlikely that I'll put in the PR for glium to be pushed forward, but we can leave this open for others to find.

@KeyMaster-
Copy link
Contributor

I started using glium recently and actually did this upgrade for the winit changes. See my fork (https://github.com/KeyMaster-/glium) for that, I only made the absolutely minimal changes to get it working, but not much was needed (see here).
I could PR this if it'd be something worth building on.

@Lokathor
Copy link
Contributor Author

that sounds great to contribute!

@est31
Copy link
Collaborator

est31 commented Jul 22, 2019

@KeyMaster- wow, that's nice! Feel free to file a PR. You should probably call the version "0.25.0-alpha1" but otherwise it looks great.

@KeyMaster-
Copy link
Contributor

Just submitted the PR, see #1757. I also pulled in the 0.25.1 changes.

@est31
Copy link
Collaborator

est31 commented Jul 23, 2019

It's released: https://crates.io/crates/glium/0.26.0-alpha1

Some examples are broken, which is a blocker for the 0.26.0 release: #1758

@est31 est31 closed this as completed Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants