Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove icon loading feature #799

Merged
merged 1 commit into from Feb 24, 2019

Conversation

Osspial
Copy link
Contributor

@Osspial Osspial commented Feb 22, 2019

  • Tested on all platforms changed
  • Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users
  • Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
  • Created an example program if it would help users understand this functionality

Removes the icon_loading feature from the eventloop-2.0 branch. This does not remove window icons as a feature - it just removes the image crate integration. This is because we've gotten so many issues/prs about the version of the image crate that maintaining our support for it seems to be far more trouble than it's worth. Not only that, but keeping the dependency will just lock us into a never-ending series of breaking changes every time image wants to bump its major version number - preventing us from ever stabilizing until image reaches 1.0, and potentially forcing a major bump after that if image ever decides to make more breaking changes after that.

Yes, this PR forces users to add some boilerplate code, but it really isn't that much.

Discussion is encouraged, of course, but I've got a strong preference towards merging this. Closes #661.

@Osspial
Copy link
Contributor Author

Osspial commented Feb 24, 2019

There seems to be overwhelming support for this so I'll go ahead and merge it.

@Osspial Osspial merged commit 3cd40ef into rust-windowing:eventloop-2.0 Feb 24, 2019
@Osspial Osspial mentioned this pull request Mar 6, 2019
kosyak pushed a commit to kosyak/winit that referenced this pull request Jul 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants