Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG.md
if knowledge of this change could be valuable to usersRemoves the
icon_loading
feature from theeventloop-2.0
branch. This does not remove window icons as a feature - it just removes theimage
crate integration. This is because we've gotten so many issues/prs about the version of theimage
crate that maintaining our support for it seems to be far more trouble than it's worth. Not only that, but keeping the dependency will just lock us into a never-ending series of breaking changes every timeimage
wants to bump its major version number - preventing us from ever stabilizing untilimage
reaches1.0
, and potentially forcing a major bump after that ifimage
ever decides to make more breaking changes after that.Yes, this PR forces users to add some boilerplate code, but it really isn't that much.
Discussion is encouraged, of course, but I've got a strong preference towards merging this. Closes #661.