Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent debug error on compute shader creation #2073

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

justincredible
Copy link
Contributor

Resolves #1718.

The Default derivation is justified by the trait implementation for HashMap. There is a slight readability improvement here, but replacing the remaining lines that use HashMap::with_hasher(Default::default()) would slightly degrade readability.

This approach to determining whether a program contains a compute stage is not valid generally, but it works for glium because the shader stages are partitioned into the two program types.

@est31 est31 merged commit b95779d into glium:master Sep 6, 2023
7 checks passed
@justincredible justincredible deleted the compute-shader branch September 6, 2023 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gpgpu example reports GL_INVALID_OPERATION
2 participants