Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Scanner.allocScratch method and don't alloc on scan path #9

Merged
merged 1 commit into from
Jul 3, 2017

Conversation

eliaslevy
Copy link
Collaborator

Adds a new method, Scanner.allocScratch, to preallocate the scratch space outside the scan code path and remove the allocation in Scanner.scan.

@gliwka gliwka self-assigned this Jul 3, 2017
@gliwka gliwka merged commit 5a0a58a into gliwka:master Jul 3, 2017
@gliwka
Copy link
Owner

gliwka commented Jul 3, 2017

Hi Elias,

Thank you for your contribution. This actually makes a lot of sense.

I've merged the change and released it in v0.4.0.

i'm happy that somebody else has a use case for this library and would love to hear more about your usecase of hyperscan-java, if you don't mind to share.

Thanks a lot

  • M.

@eliaslevy
Copy link
Collaborator Author

@gliwka Mostly using it to match HTTP traffic.

BTW, any chance of adding <scope>test</scope> to the JUnit dependency and pinning it to a version that is not RELEASE? Maven 3 no longer recognizes that tag.

@gliwka
Copy link
Owner

gliwka commented Jul 4, 2017

Fixed in #11 (v0.4.1)

Thanks for the hint - java is not really my "native" langauge 😃

@eliaslevy eliaslevy deleted the alloc-out-of-scan-path branch July 5, 2017 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants