New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[work in progress] Dropping Python 2 support #286
Merged
Merged
Changes from 16 commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
e6eaf46
refactored away externals
tommyod 5325e2a
deleted externals
tommyod 4c073f8
removed support for old sklearn
tommyod 6813f48
removed 'base.py', importing from sklearn instead
tommyod ffb92a7
Revert "flake8 in CI for tests too. verbose output from tests and slo…
tommyod 5d55acf
Revert "deleted externals"
tommyod d53f165
Revert "Revert "deleted externals""
tommyod f338929
Revert "Revert "flake8 in CI for tests too. verbose output from tests…
tommyod 46c0187
Revert "removed 'base.py', importing from sklearn instead"
tommyod 61d70d7
Revert "Revert "removed 'base.py', importing from sklearn instead""
tommyod 7c0d7ef
Revert "Revert "Revert "flake8 in CI for tests too. verbose output fr…
tommyod cad6bcc
Revert "Revert "Revert "deleted externals"""
tommyod 4dc4d31
Revert "Revert "deleted externals""
tommyod 5cb4658
Revert "Revert "flake8 in CI for tests too. verbose output from tests…
tommyod d74da91
Revert "removed 'base.py', importing from sklearn instead"
tommyod 0f684c9
reverted
tommyod 2ceda46
deleted 'externals' folder for py2 compatibility
tommyod a97fa20
mentioned python 3.5+ in README and docs
tommyod 6297254
updated urllib to Python 3 compatibility
tommyod ea8de7e
added forgotten import
tommyod 731f5fd
trying to use python 3 on circleCI
tommyod 1caa192
Revert "trying to use python 3 on circleCI"
tommyod 33c58d0
added some lines to circleCI
tommyod 9868acf
using py3 in circleCI
tommyod f6c6fba
removed apt get update from circleCI
tommyod 21d7da4
activating env in circleCI
tommyod 0672c6d
quiet installation with pip
tommyod File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,5 @@ | ||
language: python | ||
env: | ||
- PYTHON=2.7 | ||
- PYTHON=3.5 | ||
- PYTHON=3.6 | ||
- PYTHON=3.7 | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1 @@ | ||
from . import six | ||
tommyod marked this conversation as resolved.
Show resolved
Hide resolved
|
||
from . import funcsigs |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please don't remove this. We don't want a dependency on sklearn. It's a conscious choice.