Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancements #339

Merged
merged 6 commits into from
Jul 4, 2023
Merged

Enhancements #339

merged 6 commits into from
Jul 4, 2023

Conversation

carlhiggs
Copy link
Member

This pull request addresses

Item number #337 is a big one --- running a full set of analysis to verify functionality when we merge a pull request. It may require some tweaking to get this to work in the Github Action (I ran it offline as unittests successfully) --- we'll see!

…d dynamically as a function, not just on first load, as per #335
….4.5, and Docker image) to address #336 and updated test.py to address #337
…s.txt issue with optional field causing crash if not completed, as per #338
…worked fine on local computer, but in GitHub Actions workflow, I think it failed as tests were attempted in parallel)
@carlhiggs
Copy link
Member Author

As predicted, the tests didn't run smoothly when performed as actions --- i think it might be because they ran in parallel not sequentially...
https://github.com/global-healthy-liveable-cities/global-indicators/actions/runs/5450125647/jobs/9915068026?pr=339
Just did an update to see if this makes the test workflow run smoothly

…kflow to work (this is a backstep for #337, but I want to merge the changes so don't want this to hold things up)
@carlhiggs carlhiggs merged commit 3705e22 into main Jul 4, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant