fix(table): mark onClick as required in TableAction (#349)

globalbrain · Oct 3, 2023 · b5d4131 · b5d4131
1 parent fffe693
commit b5d4131
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/lib/components/STableHeader.vue b/lib/components/STableHeader.vue
@@ -29,7 +29,7 @@ const stats = computed(() => {
 // deprecated `reset` prop in favor of `actions`, remove this in next major version
 const resetAction = computed(() => {
   return props.reset
-    ? [{ label: 'Reset filters', onClick: props.onReset, type: 'info' }]
+    ? [{ label: 'Reset filters', onClick: props.onReset!, type: 'info' }] // onReset is required when reset is true
     : []
 })
 </script>

diff --git a/lib/composables/Table.ts b/lib/composables/Table.ts
@@ -191,7 +191,7 @@ export interface TableAction {
   mode?: 'neutral' | 'mute' | 'info' | 'success' | 'warning' | 'danger'
   label: string
   labelMode?: 'neutral' | 'mute' | 'info' | 'success' | 'warning' | 'danger'
-  onClick?(): void
+  onClick(): void
 }
 
 export function useTable<