Skip to content

Commit

Permalink
fix(input-number): emit null when empty is input (#111)
Browse files Browse the repository at this point in the history
  • Loading branch information
ryo-gk committed Dec 14, 2021
1 parent 5d311ed commit d417960
Show file tree
Hide file tree
Showing 2 changed files with 31 additions and 1 deletion.
2 changes: 1 addition & 1 deletion lib/components/SInputNumber.vue
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,6 @@ defineProps({
const emit = defineEmits(['update:modelValue'])
function emitUpdate(value: string): void {
emit('update:modelValue', value === '' ? null : Number(value))
emit('update:modelValue', value ? Number(value): null)
}
</script>
30 changes: 30 additions & 0 deletions tests/components/SInputNumber.spec.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
import { mount } from '@vue/test-utils'
import SInputNumber from 'sefirot/components/SInputNumber.vue'

describe('components/SNumber', () => {
it('should emit value on input', () => {
const wrapper = mount(SInputNumber)

wrapper.find('.SInputNumber .input').setValue(0)
expect((wrapper.emitted('update:modelValue') as any[][])[0][0]).toBe(0)

wrapper.find('.SInputNumber .input').setValue(2)
expect((wrapper.emitted('update:modelValue') as any[][])[1][0]).toBe(2)

wrapper.find('.SInputNumber .input').setValue(-2)
expect((wrapper.emitted('update:modelValue') as any[][])[2][0]).toBe(-2)
})

it('should emit null when value is null or empty', () => {
const wrapper = mount(SInputNumber)

wrapper.find('.SInputNumber .input').setValue(null)
expect((wrapper.emitted('update:modelValue') as any[][])[0][0]).toBe(null)

wrapper.find('.SInputNumber .input').setValue(undefined)
expect((wrapper.emitted('update:modelValue') as any[][])[1][0]).toBe(null)

wrapper.find('.SInputNumber .input').setValue('')
expect((wrapper.emitted('update:modelValue') as any[][])[2][0]).toBe(null)
})
})

0 comments on commit d417960

Please sign in to comment.