Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[next] fix(input number): emit null when empty is input #111

Merged
merged 2 commits into from
Dec 14, 2021

Conversation

ryo-gk
Copy link
Member

@ryo-gk ryo-gk commented Dec 14, 2021

Fix the problem that emits 0 when empty is input.

@ryo-gk ryo-gk added the bug Something isn't working label Dec 14, 2021
@ryo-gk ryo-gk requested a review from kiaking December 14, 2021 04:31
@ryo-gk ryo-gk self-assigned this Dec 14, 2021
@codecov
Copy link

codecov bot commented Dec 14, 2021

Codecov Report

Merging #111 (4c5b055) into next (5d311ed) will increase coverage by 3.30%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##            next    #111      +/-   ##
========================================
+ Coverage   3.48%   6.78%   +3.30%     
========================================
  Files         47      47              
  Lines        545     545              
  Branches     107     107              
========================================
+ Hits          19      37      +18     
+ Misses       526     508      -18     
Impacted Files Coverage Δ
lib/components/SInputNumber.vue 100.00% <100.00%> (+100.00%) ⬆️
lib/components/SInputBase.vue 58.33% <0.00%> (+58.33%) ⬆️
lib/components/SInputText.vue 72.72% <0.00%> (+72.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d311ed...4c5b055. Read the comment docs.

Copy link
Member

@kiaking kiaking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niiiice!

@kiaking kiaking merged commit d417960 into next Dec 14, 2021
@kiaking kiaking deleted the fix/next/input_number branch December 14, 2021 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants