Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SInputDropdown] Non nullable item still displays "remove icon" #155

Closed
kiaking opened this issue Oct 18, 2022 · 0 comments · Fixed by #165
Closed

[SInputDropdown] Non nullable item still displays "remove icon" #155

kiaking opened this issue Oct 18, 2022 · 0 comments · Fixed by #165
Assignees
@brc-dd
Labels
bug Something isn't working

Comments

@kiaking
Copy link
Member

kiaking commented Oct 18, 2022

Even the list item is not nullable, it shows "remove icon". We should hide close icon if the item is not removable (non-nullable).

👇 The "x" icon should not be displayed.

Screen Shot 2022-10-18 at 16 12 01
@kiaking kiaking added the bug Something isn't working label Oct 18, 2022
@brc-dd brc-dd self-assigned this Oct 20, 2022
@brc-dd brc-dd mentioned this issue Oct 20, 2022
Merged
kiaking added a commit that referenced this issue Oct 20, 2022
@brc-dd @kiaking
fix(input-dropdown): remove button is displayed even when item is not…
49ff573 
… removable (#155) (#165)

fix #155

Co-authored-by: Kia Ishii <kia.king.08@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brc-dd brc-dd

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: hide remove icon when only one item is selected and input is non nullable globalbrain/sefirot
2 participants
@kiaking @brc-dd