Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add STableCellPills component #179

Merged
merged 3 commits into from
Dec 23, 2022
Merged

feat: add STableCellPills component #179

merged 3 commits into from
Dec 23, 2022

Conversation

brc-dd
Copy link
Member

@brc-dd brc-dd commented Dec 22, 2022

fixes #178
fixes #177

@netlify
Copy link

netlify bot commented Dec 22, 2022

Deploy Preview for sefirot-docs ready!

Name Link
🔨 Latest commit b9d9490
🔍 Latest deploy log https://app.netlify.com/sites/sefirot-docs/deploys/63a517155ceaef0008eb5d06
😎 Deploy Preview https://deploy-preview-179--sefirot-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Dec 22, 2022

Deploy Preview for sefirot-story ready!

Name Link
🔨 Latest commit b9d9490
🔍 Latest deploy log https://app.netlify.com/sites/sefirot-story/deploys/63a51715783030000a341981
😎 Deploy Preview https://deploy-preview-179--sefirot-story.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Dec 22, 2022

Codecov Report

Base: 35.25% // Head: 34.99% // Decreases project coverage by -0.25% ⚠️

Coverage data is based on head (b9d9490) compared to base (c1368a6).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #179      +/-   ##
==========================================
- Coverage   35.25%   34.99%   -0.26%     
==========================================
  Files         101      102       +1     
  Lines        8096     8156      +60     
  Branches      214      215       +1     
==========================================
  Hits         2854     2854              
- Misses       5242     5302      +60     
Impacted Files Coverage Δ
lib/components/STableCell.vue 0.00% <0.00%> (ø)
lib/components/STableCellPills.vue 0.00% <0.00%> (ø)
lib/composables/Table.ts 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@brc-dd
Copy link
Member Author

brc-dd commented Dec 22, 2022

Also there are a bunch of warning/errors on the console when someone filters something 👀 (they were before this PR too).

@ryo-gk
Copy link
Member

ryo-gk commented Dec 22, 2022

Thanks a lot 🙌
Looking good to me!

@kiaking
Could you check, and tweak some designs if you need?

@kiaking
Copy link
Member

kiaking commented Dec 23, 2022

Also there are a bunch of warning/errors on the console when someone filters something

That's the one coming from Histoire I think... not sure what it is. It doesn't happen on actual app that uses STable component. It would be cool if we can fix it though 🤔

@kiaking kiaking merged commit 08ce426 into main Dec 23, 2022
@kiaking kiaking deleted the fix/178 branch December 23, 2022 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Table] Add STableCellPills component [Table] Error prop type on Cell component because of external type
3 participants