Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[InputYMD] Add placeholder props to SInputYMD #245

Closed
ryo-gk opened this issue Apr 12, 2023 · 0 comments · Fixed by #246
Closed

[InputYMD] Add placeholder props to SInputYMD #245

ryo-gk opened this issue Apr 12, 2023 · 0 comments · Fixed by #246
Assignees
@ryo-gk
Labels
enhancement New feature or request

Comments

@ryo-gk
Copy link
Member

ryo-gk commented Apr 12, 2023

Now, the placeholder of SInputYMD is 1998/01/14.
This placeholder is not good for some use cases.
For example, when placing the field of the start date and end date so that users can input the period, it's better if the placeholder of the start date is before the one of the end date.
@ryo-gk ryo-gk added the enhancement New feature or request label Apr 12, 2023
@kiaking kiaking changed the title Add placeholder props to SInputYMD [InputYMD] Add placeholder props to SInputYMD Apr 12, 2023
@ryo-gk ryo-gk self-assigned this Apr 13, 2023
@ryo-gk ryo-gk mentioned this issue Apr 13, 2023
Merged
kiaking added a commit that referenced this issue Apr 13, 2023
@ryo-gk @kiaking
feat(input-ymd): add placeholder option (#245) (#246)
7147678 
close #245

Co-authored-by: Kia King Ishii <kia.king.08@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ryo-gk ryo-gk

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(SInputYMD): add placeholder props globalbrain/sefirot
1 participant
@ryo-gk