Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Button] label is not centered when used inside SSheetFooterAction #276

Closed
NozomuIkuta opened this issue May 10, 2023 · 1 comment · Fixed by #274
Closed

[Button] label is not centered when used inside SSheetFooterAction #276

NozomuIkuta opened this issue May 10, 2023 · 1 comment · Fixed by #274
Labels
bug Something isn't working

Comments

@NozomuIkuta
Copy link
Contributor

when SButton's block prop is enabled and the button is used inside SSheetFooterAction, the button label comes to look like below:

Screenshot 2023-05-10 at 17 14 35

As far as I checked, the text element doesn't extend (or "flex-grow") in the button, which is in turn extended to min-width of SSheetFooterAction.

Workaround at the moment is to define styles like below where SSheetFooterAction is used.

<style scoped lang="postcss">
:deep(.SSheetFooterAction .SButton .content) {
  flex-grow: 1
}
</style>

By the way, if block prop is disabled, then the button comes to not extend to min-width of SSheetFooterAction like below:

Screenshot 2023-05-10 at 17 23 47
@NozomuIkuta NozomuIkuta changed the title [Button] label is not centered when used inside SSheetFooterAction [Button] label is not centered when used inside SSheetFooterAction May 10, 2023
@kiaking
Copy link
Member

kiaking commented May 10, 2023

Oh yeah I think this is fixed by #274

👉 https://github.com/globalbrain/sefirot/pull/274/files#r1189356381

@kiaking kiaking added the bug Something isn't working label May 10, 2023
kiaking pushed a commit that referenced this issue May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants