Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Avatar] Image is not filled when aspect ratio is not 1:1 #479

Closed
kiaking opened this issue Feb 22, 2024 · 3 comments · Fixed by #498
Closed

[Avatar] Image is not filled when aspect ratio is not 1:1 #479

kiaking opened this issue Feb 22, 2024 · 3 comments · Fixed by #498
Assignees
@brc-dd
Labels
bug Something isn't working

Comments

@kiaking
Copy link
Member

kiaking commented Feb 22, 2024

Do object-fit: cover.

Screenshot 2024-02-22 at 12 46 25
@kiaking kiaking added the bug Something isn't working label Feb 22, 2024
@brc-dd
Copy link
Member

brc-dd commented Mar 11, 2024

This seems to be already fixed?

@kiaking
Copy link
Member Author

kiaking commented Mar 11, 2024

Oh really...? I don't remember touching it so, not sure 🤔 Need to test 👀

@brc-dd
Copy link
Member

brc-dd commented Mar 11, 2024

Ok, wait no. My image was wrong.

@brc-dd brc-dd self-assigned this Mar 11, 2024
@brc-dd brc-dd mentioned this issue Mar 11, 2024
Merged
kiaking pushed a commit that referenced this issue Mar 12, 2024
@brc-dd
fix(avatar): fill image when its not square (#479) (#498)
ee99078 
close #479
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brc-dd brc-dd

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(avatar): fill image when its not square globalbrain/sefirot
2 participants
@kiaking @brc-dd