Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Table] Add a way to highlight selected row #483

Closed
kiaking opened this issue Feb 28, 2024 · 2 comments · Fixed by #499
Closed

[Table] Add a way to highlight selected row #483

kiaking opened this issue Feb 28, 2024 · 2 comments · Fixed by #499
Assignees
Labels
enhancement New feature or request

Comments

@kiaking
Copy link
Member

kiaking commented Feb 28, 2024

When making table selectable, it would be cool if we can highlight that row. Not sure how API should look like.

I think the bg color should be set to --c-bg-mute-1 in order to distinguish from hover style. But maybe it makes texts harder to read... so --c-bg-elv-4 could be enough 🤔

@kiaking kiaking added the enhancement New feature or request label Feb 28, 2024
@brc-dd brc-dd self-assigned this Mar 11, 2024
@brc-dd
Copy link
Member

brc-dd commented Mar 11, 2024

hover has --c-bg-elv-4 -- it'd be same for both then 👀

.row:hover & {
background-color: var(--c-bg-elv-4);

@kiaking
Copy link
Member Author

kiaking commented Mar 11, 2024

@brc-dd
Yeah it would. So, the down side is user will not notice the change until they remove the mouse from that row after selecting it 👀 But... I think it would be noticeable enough. I hope 🙏

kiaking added a commit that referenced this issue Mar 12, 2024
close #483

Co-authored-by: Kia King Ishii <kia.king.08@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants