PHP array registry would be more efficient

[Bilge]

The IBAN registry is currently stored in a text file which is parsed each time it is loaded. This has a significant overhead compared with array config. The advantages of using an array:

• No need to parse anything. All line and pipe-separator parsing code can be deleted.
• Registry can be cached by PHP automatically using opcache.
• Loads faster.
• More maintainable (no more very long lines).

[globalcitizen]

I agree, it could be enhanced performance wise.

However, people depend on the current format.

If you submit a PR that caches the current format in an intermediate format without introducing dependencies I would consider it.

[Bilge]

Why would anyone depend on the current file format? They should use the library's API, not the file directly.

…

On Thu, 13 Feb 2020, 06:04 Walter Stanish, ***@***.***> wrote: I agree, it could be enhanced performance wise. However, people depend on the current format. If you submit a PR that caches the current format in an intermediate format without introducing dependencies I would consider it. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#98?email_source=notifications&email_token=AADS4YSNYTU6JUB6YTIYC33RCTPITA5CNFSM4KTANO72YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELTQVAQ#issuecomment-585566850>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADS4YWW4OHZYANLZWJ3PILRCTPITANCNFSM4KTANO7Q> .

[globalcitizen]

90% of the life of software is maintenance. As a maintainer, it is my job to care about such things to save other people hassle.

[Bilge]

I don't think we're even talking about the same thing at this point.