Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new CZ IBAN examples #121

Merged
merged 1 commit into from
Jan 8, 2023
Merged

new CZ IBAN examples #121

merged 1 commit into from
Jan 8, 2023

Conversation

Triplkrypl
Copy link
Contributor

@Triplkrypl Triplkrypl commented Jan 5, 2023

First two contains first part of CZ national format, we call it prefix and it is optional. I notice than previous IBANs have this only with zeros, which is in national format ignored and considered as empty.

Last one is valid, but is little trap for users. Ends with zero and if user adds one zero in the end in national format by mistake checksum is still fine 😢.

@globalcitizen globalcitizen merged commit 0a65ded into globalcitizen:master Jan 8, 2023
@globalcitizen
Copy link
Owner

globalcitizen commented Jan 8, 2023

Thanks!

These pass the IBAN checksum according to the current codebase.

I am unsure if I understand your comment fully. Could you perhaps share a demo script? Thanks.

$ cd utils
$ php validate-list.php example-ibans/cz-ibans
CZ06 3500 0000 0010 0047 2301 ... ok (no national checksum)
CZ12 3500 0000 0013 3047 2304 ... ok (no national checksum)
CZ10 3500 0000 0012 2047 2303 ... ok (no national checksum)
CZ3855000000005041018525 ... ok (no national checksum)
CZ35 0300 0000 0002 2514 9068 ... ok (no national checksum)
CZ8427000000002112049123 ... ok (no national checksum)
CZ56 0600 0000 0002 1193 3046 ... ok (no national checksum)
CZ12 0600 0000 0002 1193 3062 ... ok (no national checksum)
CZ9101000000000021645051 ... ok (no national checksum)
CZ6101000000430185770297 ... ok (no national checksum)
CZ27 0710 0010 1100 0792 2681 ... ok (no national checksum)
CZ13 0300 0000 0003 0092 2760 ... ok (no national checksum)

@Triplkrypl
Copy link
Contributor Author

I am sorry for some misunderstand, CZ13 0300 0000 0003 0092 2760 IBAN is really OK, I added the IBAN into examples because is valid. Maybe some Czech banks avoid using bank accounts ending with zero for increase national checksum robustness, so can be less common.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants