Fix: allow many rule action overrides #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've also added a example file of RuleActionOverrides for people. |
|
Thank you already released in 3.1.4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
This PR implements two needed fixes and one eye candy modification:
Error message might confuse people: This is just for eye candy and for helping newcomers. The first time I ran the repo I saw it and it scared me a bit. :)Fix: AWS only accepts RuleActionOverrides in camelCase: this commit was what allowed me to specify RuleActionOverrides, without it CloudFormation would throw a weird error.Allow all types of OverrideActions: This is for the future, if people wants to implement RuleActionOverrides other then "Count" now they can.Wish you a great weekend! ^^