Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Submission-> It's possible to finalize submission with a Receiver not associated to the context #31

Closed
fpietrosanti opened this issue Feb 22, 2013 · 2 comments
Closed

Submission-> It's possible to finalize submission with a Receiver not associated to the context #31

fpietrosanti opened this issue Feb 22, 2013 · 2 comments
Labels
C: Backend T: Bug U: Whistleblower

Comments

@fpietrosanti
Copy link
Contributor

Following the discovery of the bug #30 i was able to finalize (submit) a submission on a receiver that's not associated to a context.

The server and client should both check that a submission can be done only with a receiver that's effectively associated with the context for which it's submitting to.
@fpietrosanti
Copy link
Contributor Author

With #30 fixed on client, this became a GLB that should properly check that the receivers being submitted to are properly part of the context for which a submission is being finalized.

@vecna
Copy link
Contributor

vecna commented Feb 25, 2013

you was right, in fact this enforcing has not been ported after the refactor.
https://github.com/globaleaks/GLBackend/commit/b0353f28fbcb2853befcf49533973a6ee2d32647
I've put an unitTest to fuzz over submission, just in case other elements need to be fixed/tested

@vecna vecna closed this as completed Feb 25, 2013
mmaker pushed a commit to mmaker/GlobaLeaks that referenced this issue Oct 27, 2014
@vecna
https://github.com/globaleaks/GlobaLeaks/issues/31
b0353f2
mmaker pushed a commit to mmaker/GlobaLeaks that referenced this issue Oct 27, 2014
@hellais
Further improvements of admin interfaces
2d993e7 
* Change how receivers and contexts are picked to not use select2
  fixes: globaleaks#68
  and closes globaleaks#31
* Move the field editor into a separate template
* General improvements to look and feel of app
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C: Backend T: Bug U: Whistleblower
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vecna @fpietrosanti