Improve DDL management for custom functions #17
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes:
- DDL is not activated via sqlalchemy events; this ensures that unit tests work
- DDL is not exposed via a `create(connection)` or `drop(connection)` method;
Downstream projects will have to generate their own migrations.
- Small API change from `last.over_(foo)` to `last.of(foo)`
jessemyers
commented
Mar 2, 2018
| @@ -0,0 +1 @@ | |||
| recursive-include microcosm_eventsource *.ddl | |||
There was a problem hiding this comment.
DDL files are now included as text in the dist
There was a problem hiding this comment.
How are these expected to be accessed?
There was a problem hiding this comment.
Ah, I see the resource_string call below.
jessemyers
commented
Mar 2, 2018
| return resource_string("microcosm_eventsource", f"ddl/{name}.{action}.ddl").decode("utf-8") | ||
|
|
||
|
|
||
| # register custom DDL when calling `create_all` or `drop_all` |
jessemyers
commented
Mar 2, 2018
| event = column.class_ | ||
| return cls(column).over( | ||
| order_by=event.clock.asc(), | ||
| partition_by=event.container_id, | ||
| ) | ||
|
|
||
| @staticmethod | ||
| def create(connection): |
There was a problem hiding this comment.
Downstream services will have to write these statements themselves.
GabeLambda
approved these changes
Mar 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
DDL is not activated via sqlalchemy events; this ensures that unit tests work
DDL is not exposed via a
create(connection)ordrop(connection)method;Downstream projects will have to generate their own migrations.
Small API change from
last.over_(foo)tolast.of(foo)