Initial event-sourced state machine #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes: - An abstraction for defining event type enumerations and their behavior - A meta class for defining new event models - A base store for common event persistence - A base controller for common event business logic - A starting place for resources and routes
|
LGTM I like the accumulation idea to differentiate between events that cause state changes and events that dont. |
netama
reviewed
Apr 25, 2017
| """ | ||
| if version is None: | ||
| return 1 | ||
| if self.is_restarting: |
There was a problem hiding this comment.
so the first event cannot be is_restarting?
There was a problem hiding this comment.
I think the versioning logic allows it but the transitioning logic might not.
- The first version is always 1
- If the first event were of a restarting type, it would still start at version 1
- If the restarting type came later, you'd get version N+1
I don't think it's easy to express "initial or [some other condition]" yet as a state transition.
There was a problem hiding this comment.
Should now be addressed in develop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes: