remove string cast from Page serialization #100
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
LGTM even better |
adamhadani
commented
Feb 6, 2017
| if isinstance(value, (UUID, Enum)): | ||
| return str(value) | ||
|
|
||
| return value |
There was a problem hiding this comment.
ping @jessemyers I ended up adding this to_value method as a unit-test was failing here when trying to pass enum and UUID objects into the from_query_string factory and expect to see them serialized properly into a JSON response (as strings).
-
I'm not sure this is a case we care about so perhaps unit-test is off?
-
In any case, I think Enum/UUID covers most mainstream use-cases for non offset/limit parameters so this would preserve backward-compatibility pretty well. removing this might break a bunch of services in hard to debug ways.. WDYT?
adamhadani
deleted the
feature/GLOB-5923-support-postloaded-search-params
branch
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes this issue