Circle 1->2 #42
Merged
Circle 1->2 #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moshez
commented
Jul 5, 2018
| # install dependencies for loading ecs task definitions | ||
| command: | | ||
| eval $(aws ecr get-login --no-include-email) | ||
| sudo pip install --upgrade elcaminoreal |
There was a problem hiding this comment.
I know I know. but I have to do one manual merge of something so I can know that the deploy flow works correctly before I can merge globality build.
omri-globality
approved these changes
Jul 6, 2018
There was a problem hiding this comment.
LGTM.
I understand that it's only a auto generator for the existing circleCI config files, but it might worth to see why we're not it in this way (Postgres for instance):
https://github.com/globality-corp/globality-service-data/blob/develop/.circleci/config.yml#L57
In this way the postgres container will run as a daemon and will be accessible for other containers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.